Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dgf bug #463

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Fixed dgf bug #463

merged 10 commits into from
Apr 10, 2024

Conversation

teddygroves
Copy link
Member

@teddygroves teddygroves commented Mar 26, 2024

Fixes #462

Checklist:

  • Updated any relevant documentation na
  • Add an adr doc if appropriate na
  • Include links to any relevant issues in the description
  • Unit tests passing
  • Integration tests passing

@teddygroves teddygroves requested a review from carrascomj March 26, 2024 15:06
Copy link
Member

@carrascomj carrascomj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

{exploc = 1, scale = 0.6, enzyme = "r2", metabolite = "M1", compartment = "c", modification_type = "inhibition"},
]

# dgf = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove the commented data.

@carrascomj
Copy link
Member

It seems like arviz and scipy versions are now incompatible with each other.

@teddygroves teddygroves reopened this Apr 10, 2024
@carrascomj carrascomj merged commit 99ecc35 into main Apr 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init free dGfs properly
2 participants