Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use priors for fixed dgfs #451

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Don't use priors for fixed dgfs #451

merged 1 commit into from
Oct 20, 2023

Conversation

teddygroves
Copy link
Member

@teddygroves teddygroves commented Oct 19, 2023 •
edited
Loading

This change fixes a bug that I just released in #449: the priors for fixed formation energy parameters were still being used to calculate the log probability.

Checklist:

  • Updated any relevant documentation
  • Add an adr doc if appropriate
  • Include links to any relevant issues in the description
  • Unit tests passing
  • Integration tests passing

NicholasCowie
NicholasCowie approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@NicholasCowie NicholasCowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested method independently

@NicholasCowie NicholasCowie merged commit fc5c1fc into main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasCowie NicholasCowie NicholasCowie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teddygroves @NicholasCowie