Add prefix: dpvocab #1240

github-actions · 2024-10-31T18:39:56Z

src/bioregistry/data/bioregistry.json

bgyori · 2024-11-01T02:45:44Z

src/bioregistry/data/bioregistry.json

+    "publications": [
+      {}
+    ],


Suggested change

"publications": [

{}

],

"publications": [

{

"doi": "10.48550/arXiv.2404.13426"

}

],

bgyori · 2024-11-01T02:49:29Z

src/bioregistry/data/bioregistry.json

+    "comment": "The resource itself specifies a preferred prefix of `dpv` but this is already claimed in Bioregistry by the Description of Plant Viruses (https://bioregistry.io/registry/dpv)",
+    "contributor": {
+      "email": "[email protected]",
+      "github": "caufieldjh",
+      "name": "Harry Caufield",
+      "orcid": "0000-0001-5705-7831"
+    },


Suggested change

"comment": "The resource itself specifies a preferred prefix of `dpv` but this is already claimed in Bioregistry by the Description of Plant Viruses (https://bioregistry.io/registry/dpv)",

"contributor": {

"email": "[email protected]",

"github": "caufieldjh",

"name": "Harry Caufield",

"orcid": "0000-0001-5705-7831"

},

"comment": "The resource itself specifies a preferred prefix of `dpv` but this is already claimed in Bioregistry by the Description of Plant Viruses (https://bioregistry.io/registry/dpv)",

"contact": {

"email": "[email protected]",

"github": "coolharsh55",

"name": "Harshvardhan J. Pandit",

"orcid": "0000-0002-5068-3714"

},

"contributor": {

"email": "[email protected]",

"github": "caufieldjh",

"name": "Harry Caufield",

"orcid": "0000-0001-5705-7831"

},

bgyori · 2024-11-01T02:56:05Z

Thanks @caufieldjh! I made a bunch of suggestions but there seems to be a glitch in GitHub and I can't apply them through the UI here.

bgyori · 2024-11-01T16:27:05Z

Oh no, the Github action is buggy and force pushed the wrong content to this branch - we'll work on reconstructing it.

nagutm · 2024-11-01T17:10:44Z

Oh no, the Github action is buggy and force pushed the wrong content to this branch - we'll work on reconstructing it.

See #1244

This PR fixes #1240 (comment) which was caused by a buggy github-actions that forcefully overwrote the content of the `dpvocab` prefix with another prefix. Co-authored-by: Mufaddal Naguthanawala <[email protected]>

Co-Authored-By: Benjamin M. Gyori <[email protected]>

Co-Authored-By: Benjamin M. Gyori <[email protected]> Co-Authored-By: Mufaddal Naguthanawala <[email protected]>

Co-Authored-By: Harry Caufield <[email protected]>

The GitHub Actions workflow for registering new prefixes through the issue template is reusing the same branch for each new issue, leading to the content of the second pull request overwriting the first. This was first noticed in this PR: #1240. This occurs because the workflow does not generate a unique branch for each new issue. As a result, subsequent PRs are force-pushing content to the previous PR's branch instead of creating new, independent branches for each PR. This PR introduces the following changes to the `new_prefix_pr.yml` to address this issue: - Create a step to extract the issue number from the issue URL. - Dynamically generate a unique branch name (`create-pull-request/patch-<issue_number>`) for each new issue. - Modify the PR creation step to use the dynamically generated branch name, ensuring that each PR is linked to its own unique branch. --------- Co-authored-by: Mufaddal Naguthanawala <[email protected]> Co-authored-by: Benjamin M. Gyori <[email protected]>

github-actions bot added New Used in combination with prefix, metaprefix, or collection for new entries Prefix labels Oct 31, 2024

github-actions bot changed the title ~~Add prefix: gtdb~~ Add prefix: dpvocab Oct 31, 2024

github-actions bot force-pushed the create-pull-request/patch-21ea943 branch from 33e2274 to 963e5b5 Compare October 31, 2024 18:49