Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix: gmmid #1196

Closed
wants to merge 4 commits into from
Closed

Add prefix: gmmid #1196

wants to merge 4 commits into from

Conversation

nagutm
Copy link
Collaborator

@nagutm nagutm commented Oct 9, 2024

No description provided.

@cthoyt cthoyt added Prefix New Used in combination with prefix, metaprefix, or collection for new entries labels Oct 20, 2024
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please highlight in the description of the new record what is the actual semantic space - this is another instance where there seems to be confusion between curating information about a database, and the Bioregistry's actual goal of curating information about semantic space.

Here, it appears the URI format (e.g., http://www.gmmid.cn/GeneComposition?params=583) is for a page on allele composition for a gene allele. Therefore, the record should mention something about this in the description.

There are other entity types on this website like http://www.gmmid.cn/GeneComposition2?params=1 for an allele composition for a gene category, and http://www.gmmid.cn/GeneCategory2?params=1272 for a gene category. When you're curating a new resource, do a little exploring to try and identify when there are multiple possible semantic spaces (entity types) that the site has pages for. Then it might be the case that you should curate multiple prefixes about the same database. Then, the style is typically to make a prefix like gmmid.allele or gmmid.category where there is a dot between the database name and the entity type

@cthoyt cthoyt changed the title New prefix: gmmid Add prefix: gmmid Oct 22, 2024
@nagutm
Copy link
Collaborator Author

nagutm commented Oct 28, 2024

Upon revisiting this curation, I've noticed that the resource appears to be poorly maintained. Many of the webpages aren't resolving as expected which raises questions about the overall quality of the resource. The search function seems buggy and does not make it easy to look up entries for various entities.

These are 3 examples that @cthoyt noted, but all three resolve to layout pages without any actual information.
http://www.gmmid.cn/GeneComposition?params=583
http://www.gmmid.cn/GeneComposition2?params=1
http://www.gmmid.cn/GeneCategory2?params=1272

Perhaps, this should be considered a not_notable case as discussed here: #1225 (comment) ?

Appreciate any feedback on this matter

@bgyori
Copy link
Contributor

bgyori commented Oct 28, 2024

Sure, @nagutm, let's close this then, it can always be revisited later if needed.

@bgyori bgyori closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Used in combination with prefix, metaprefix, or collection for new entries Prefix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants