-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix: obci #1175
Add prefix: obci #1175
Conversation
Thanks for the contribution @nataled! A few comments and questions:
|
df9b23e
to
eb4ff3a
Compare
Hi @bgyori,
Thanks for your suggestions and questions! |
I am not for or against this, just noting that there is a minor risk involved here:
I don't think we need to act on this now, just something to think about |
some other thoughts on the situation in https://cthoyt.com/2023/03/11/obolibrary-masquerade.html |
From @nataled's comments I got the sense that this has been already submitted to the OBO Foundry and that it was only a question of time for the URLs to start resolving. So I didn't consider that possibility that it was "unsanctioned" in any way. If this is what happened here then we could make it a policy to not register OBO PURLs unless already integrated into the OBO Foundry first (and then imported via the ingestion pipeline here). |
@matentzn I submitted this prefix in anticipation of the submitting to the Foundry. Obviously if the ontology fails that submission, I'll need to revise the purls. |
(I'm actually going to submit probably tomorrow.) |
Yeah I know, this was not so much a comment about this case, just a minor comment about tightening the SOP. For example, I would, personally, forbid the manual curation of OBO PURL URI prefixes in bioregistry altogether and just wait until the ETL pulls in the prefix from obo metadata. But no strong thoughts. If you think that's too much let's leave it as is.. |
My interpretation of the 'no clashing prefixes' directive, from the Foundry perspective, is that there must not be a registered prefix from a different resource. Perhaps a minor distinction, but the effect can be major. The tightening of the SOP (I am unclear as to whether you're referring to a Foundry SOP or to a Bioregistry SOP; here I presume the former) would prevent, for example, an ontology that has been in Bioportal from later applying to be part of the Foundry. I doubt that's the intention. If you are concerned about the SOP from the Bioregistry perspective, I have less of a concern other than the one that prompted me to submit our prefix prior to Foundry submission: multiple potential projects dealing with the same domain. I already saw submission of an ontology (BMO at the time, later BMONT) that used a prefix we originally intended to use ourselves. |
Closes #1174