[FIX] Edit Domain no longer forgets its settings #6415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6415 +/- ##
=======================================
Coverage 87.62% 87.63%
=======================================
Files 321 321
Lines 69056 69084 +28
=======================================
+ Hits 60513 60540 +27
- Misses 8543 8544 +1 |
janezd
force-pushed
the
edit-domain-noncontext
branch
12 times, most recently
from
2699d6b
to
c2926df
Compare
janezd
force-pushed
the
edit-domain-noncontext
branch
from
c2926df
to
d59c045
Compare
janezd
force-pushed
the
edit-domain-noncontext
branch
from
3cf75c6
to
c5fa7b7
Compare
janezd
changed the title
janezd
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6414, if I'm guessing correctly.
None of context settings were variables, so all contexts always matched. While contexts piled up, the widget most likely picked the most recent context and used whatever was applicable.
Description of changes
Instead of context setting with changes for particular domain, the widget now uses a schema-only settings with hints that are matched to any applicable variables. To prevent bloating, up to 1000 hints are kept (unless the current domain contains more).
Includes