[ENH] Data Table: Subset input #6405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6405 +/- ##
==========================================
+ Coverage 87.62% 87.65% +0.02%
==========================================
Files 321 321
Lines 69056 69149 +93
==========================================
+ Hits 60513 60612 +99
+ Misses 8543 8537 -6 |
ales-erjavec
force-pushed
the
owtable-subset-input
branch
from
846f347
to
20dec52
Compare
ales-erjavec
changed the title
|
/rebase |
|
It looks good to me. One thing, that could also be handled is to retain the selection when connecting/disconnecting the subset. |
ales-erjavec
force-pushed
the
owtable-subset-input
branch
from
20dec52
to
d096f17
Compare
ales-erjavec
force-pushed
the
owtable-subset-input
branch
from
d096f17
to
e379aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes: #6315
Add Data Subset input and indicate the subset in the table
Uses opacity of non subset data to emphasize subset to match other visualization widgets, and also adds an indicator to the row header (I don't like either).
Description of changes
Add subset input
Includes