[FIX] Edit Domain - set have_time and have_date to time variables #6324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6324 +/- ##
=======================================
Coverage 87.48% 87.49%
=======================================
Files 316 316
Lines 67984 67984
=======================================
+ Hits 59475 59480 +5
+ Misses 8509 8504 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When transforming continuous variable to time, Edit Domain does not set
have_timeandhave_dateattributes.Fixes #5648
Description of changes
Set to mentioned attributes when transforming Continuous to TimeVariable
Additionally, when implementing #5819, it was agreed that CountinousVariable always transforms to Time as UNIX epoch (seconds from 1970-01-01). Still format selection dropdown remained active, which can confuse the user. In this PR, I lock the format selection dropdown when transforming ContinousVariable (and TimeVariable - which was done already before).
Includes