Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Group By - fix std and sum for TimeVariable #6133

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Sep 9, 2022

Issue

Fixe #6125

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec added the needs discussion Core developers need to discuss the issue label Sep 9, 2022
@PrimozGodec
Copy link
Contributor Author

/rebase

@janezd janezd self-assigned this Sep 30, 2022
@markotoplak markotoplak removed the needs discussion Core developers need to discuss the issue label Sep 30, 2022
@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #6133 (2400565) into master (2979b21) will increase coverage by 0.00%.
The diff coverage is 95.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6133   +/-   ##
=======================================
  Coverage   86.48%   86.48%           
=======================================
  Files         315      315           
  Lines       67774    67797   +23     
=======================================
+ Hits        58616    58637   +21     
- Misses       9158     9160    +2     

@VesnaT
Copy link
Contributor

VesnaT commented Sep 30, 2022

There is a problem with saved settings. If the Sum had been checked, it cannot be unchecked (it's disabled). This should be handled in settings migration.
image

@PrimozGodec PrimozGodec force-pushed the fix-groupby-tv branch 4 times, most recently from 1c20688 to c2d3b88 Compare September 30, 2022 10:48
@markotoplak markotoplak changed the title Group By - fix std and sum for TimeVariable [FIX] Group By - fix std and sum for TimeVariable Sep 30, 2022
@VesnaT VesnaT merged commit e7879b3 into biolab:master Sep 30, 2022
@PrimozGodec PrimozGodec deleted the fix-groupby-tv branch September 30, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants