Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owrocanalysis: Fix an index error in custom tick calculation #5904

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-5902

Also the plot displays custom ticks for the first classifier only even when multiple are displayed and for Merge Predictions from Folds curves even if different combining/averaging is selected.

Description of changes

Fix an index error in custom tick calculation
Also check so that the ticks actually apply to the displayed points

Includes
  • Code changes
  • Tests
  • Documentation

Also check so that the ticks actually apply to the displayed points
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #5904 (dc6ad19) into master (9af442d) will decrease coverage by 0.01%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master    #5904      +/-   ##
==========================================
- Coverage   86.29%   86.28%   -0.02%     
==========================================
  Files         315      315              
  Lines       66830    66833       +3     
==========================================
- Hits        57674    57667       -7     
- Misses       9156     9166      +10     

@janezd janezd self-assigned this Mar 17, 2022
@janezd janezd merged commit 93cf05f into biolab:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROC curve: clicking on list of classifiers causes crash
2 participants