-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Server embedder: use queue, handle unsuccessful requests at the end #5835
Merged
markotoplak
merged 2 commits into
biolab:master
from
PrimozGodec:embedders-change-order
Feb 25, 2022
Merged
[ENH] Server embedder: use queue, handle unsuccessful requests at the end #5835
markotoplak
merged 2 commits into
biolab:master
from
PrimozGodec:embedders-change-order
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
embedders-change-order
branch
from
February 8, 2022 15:09
3782737
to
a4f8146
Compare
Codecov Report
@@ Coverage Diff @@
## master #5835 +/- ##
==========================================
+ Coverage 86.24% 86.25% +0.01%
==========================================
Files 315 315
Lines 66672 66695 +23
==========================================
+ Hits 57503 57531 +28
+ Misses 9169 9164 -5 |
PrimozGodec
force-pushed
the
embedders-change-order
branch
2 times, most recently
from
February 9, 2022 10:22
a9bafc3
to
77db719
Compare
PrimozGodec
changed the title
Server embedder: use queue, handle unsuccessful requests at the end
[ENH] Server embedder: use queue, handle unsuccessful requests at the end
Feb 9, 2022
markotoplak
reviewed
Feb 21, 2022
markotoplak
reviewed
Feb 21, 2022
markotoplak
reviewed
Feb 21, 2022
markotoplak
reviewed
Feb 21, 2022
markotoplak
reviewed
Feb 21, 2022
markotoplak
reviewed
Feb 21, 2022
markotoplak
reviewed
Feb 21, 2022
@PrimozGodec, I like the concept and structuring. I left you some minor comments and suggestions. In the end, I think I found:
|
PrimozGodec
force-pushed
the
embedders-change-order
branch
from
February 22, 2022 10:34
77db719
to
c9c6443
Compare
PrimozGodec
force-pushed
the
embedders-change-order
branch
from
February 23, 2022 12:02
c9c6443
to
9f5322a
Compare
PrimozGodec
force-pushed
the
embedders-change-order
branch
from
February 23, 2022 12:04
9f5322a
to
f3a9dde
Compare
@markotoplak it should be ready now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Server embedder retries sending unsuccessful requests immediately after the fauliture.
Since it is possible that the server needs longer to compute (the request was unsuccessful because of timeout) the results (the server will cache the result when finished) it is better to retry later (there is a higher chance that the server already finished processing).
Description of changes
Implemented described behaviour. To achieve it I needed to change embedders to use Queue instead of just gathering the results.
Includes