Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] owfeaturestatistics: Fix implicit int conversion error on resize #5799

Conversation

ales-erjavec
Copy link
Contributor

Issue

Feature Statistics widget raises an error on Python 3.10 (warning in Python 3.9) on widget resize due to implicit conversion to int.

----------------------------- TypeError Exception -----------------------------
Traceback (most recent call last):
  File "/home/ales/devel/orange3/Orange/widgets/data/owfeaturestatistics.py", line 687, in bind_histogram_aspect_ratio
    self.verticalHeader().setDefaultSectionSize(effective_height)
TypeError: setDefaultSectionSize(self, int): argument 1 has unexpected type 'float'
-------------------------------------------------------------------------------

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #5799 (def5b0d) into master (f7b522f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5799   +/-   ##
=======================================
  Coverage   86.12%   86.13%           
=======================================
  Files         316      316           
  Lines       66386    66386           
=======================================
+ Hits        57176    57181    +5     
+ Misses       9210     9205    -5     

@markotoplak
Copy link
Member

Thanks!

@markotoplak markotoplak merged commit 077e384 into biolab:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants