[FIX] Update (and test) minimum dependencies #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
oldest
branch
2 times, most recently
from
64eefa6
to
92fd3b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #5781 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 316 316
Lines 66382 66382
=======================================
Hits 57168 57168
Misses 9214 9214 |
markotoplak
force-pushed
the
oldest
branch
3 times, most recently
from
d8ee242
to
d770920
Compare
markotoplak
changed the title
markotoplak
changed the title
|
@JakaKokosar, do you know of a better way for testing this? |
markotoplak
force-pushed
the
oldest
branch
2 times, most recently
from
3debdca
to
69a3da2
Compare
|
The last failed test is not connected to this PR. |
…currently installed)
This is how we do it in add-ons. LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Our dependency list is stale. Occasionally tests fail in my valid but old python environment.
Description of changes
I added testing with oldest dependencies.
There are still requirements without specified versions. I left them as they were, for now, for better clarity of the changes in this PR (and due to some laziness). These should get defined in another PR.