[ENH] Scatterplot: Use opacity for contrast #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
subset-visibility
branch
from
0b73ef4
to
d6261dd
Compare
|
Alternative -- better, I think: decrease opacity for non-subset points faster than for the subset. This solution has a single slider which controls both, opacity and contrast at the same time. Two sliders would, I think, have to have the same effect as this single slider, but with more work from the user.
That's what it looks like: |
janezd
force-pushed
the
subset-visibility
branch
from
d6261dd
to
5a46b6c
Compare
janezd
changed the title
|
I'd appreciate a quick review (from the point of the user for now) before I update the failing tests. @ajdapretnar or @markotoplak, maybe? |
|
I'm happy to do it. |
janezd
force-pushed
the
subset-visibility
branch
from
5a46b6c
to
692184b
Compare
janezd
force-pushed
the
subset-visibility
branch
from
692184b
to
df2369d
Compare
Codecov Report
@@ Coverage Diff @@
## master #5684 +/- ##
==========================================
- Coverage 86.12% 86.12% -0.01%
==========================================
Files 315 315
Lines 66074 66081 +7
==========================================
+ Hits 56905 56911 +6
- Misses 9169 9170 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref: #5425
Instead of introducing a new slider, the opacity slider behaves differently in presence of a subset: it still regulates the opacity of the brush of subset, but at the same time it decreases the opacity of the pen of points not in the subset. The slider is still named opacity because I don't think the user will notice that (s)he now essentially regulates the contrast.
For now I implemented this for discrete coloring. If we decide that we like it, I'll change the continuous palette and monochromatic scatterplot in the same fashion.
Comments welcome.
Description of changes
Includes