Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: extend aggregate module by preprocessing #5678

Closed
wants to merge 1 commit into from

Conversation

mw25
Copy link
Contributor

@mw25 mw25 commented Nov 2, 2021

Issue

These are the modifications of OrangeTableGroupBy and Table.groupby() to allow preprocessing / range selection for each group, mentioned in #5541 (comment)

This allows preprocessing via scripting. Optionally, one could make a widget that is based on this.

Description of changes

The Table.groupby() functions gets a new parameter with which the preprocessing can be set.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec
Copy link
Contributor

Thank you for your contribution.

I would prefer it if the implementation of aggregate remains as it is. Since aggregation is a two-step operation one can extend this module when needed and add preprocessing there.

For example, if that kind of preprocessing is required in a time-series add-on, group-by can be extended there.

@janezd janezd added the needs discussion Core developers need to discuss the issue label Nov 25, 2021
@janezd janezd assigned janezd and unassigned PrimozGodec Nov 26, 2021
@janezd janezd removed the needs discussion Core developers need to discuss the issue label Nov 26, 2021
@janezd
Copy link
Contributor

janezd commented Nov 26, 2021

We discussed this today at live meeting. We agreed with what @PrimozGodec wrote above.

@janezd janezd closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants