[FIX] table_to_frame - handle numeric columns with dtype=object #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
table_to_frame-fix
branch
from
c8f7cc2
to
3758d85
Compare
Codecov Report
@@ Coverage Diff @@
## master #5474 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 304 304
Lines 61652 61652
=======================================
Hits 53240 53240
Misses 8412 8412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
table_to_framefails when array (usually metas) have dtype=object and column holds numeric values. Look newly-added test.Description of changes
Use
pd.isnullinstead ofnp.isnanwhich correctly handle columns with dtype=object.Includes