[FIX] owdataset: Do not capture self in closure #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterize and move the functions out of the class.
ales-erjavec
force-pushed
the
datasets-no-self-capture
branch
from
73310de
to
db6e84f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5198 +/- ##
==========================================
+ Coverage 84.82% 85.06% +0.23%
==========================================
Files 288 298 +10
Lines 60358 60816 +458
==========================================
+ Hits 51197 51731 +534
+ Misses 9161 9085 -76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
OWDataSets captures
selfin a closure executing in a worker thread.See: biolab/orange3-single-cell#381 (comment)
Description of changes
Parameterize and move the functions out of the class.
Includes