[FIX] MDS: Move lines when points are jittered #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4920 +/- ##
==========================================
- Coverage 84.12% 84.09% -0.03%
==========================================
Files 283 278 -5
Lines 57819 56994 -825
==========================================
- Hits 48640 47931 -709
+ Misses 9179 9063 -116 |
|
This fixes the problem at hand, so I am merging. However, even on master, things gets slow (even for zoo) when changing sliders (jittering and show similar pairs). Are we calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4898 ...
Description of changes
... by calling
update_pairsfromupdate_jitteringand ...Includes
... but no tests because a test would be trivial (
update_pairs.assert_called), or it would add yet another test that would run MDS and increase the running time, or it would require lots of mocking (and be trivial at the end, again).