HeatMap: Prevent overscaling column annotations #4775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdapretnar
changed the title
| @@ -512,7 +512,7 @@ def setHeatmaps(self, parts: 'Parts') -> None: | |||
| items=labels, parent=self, | |||
| alignment=Qt.AlignLeft | Qt.AlignVCenter, | |||
| orientation=Qt.Horizontal, | |||
| autoScale=True, | |||
| autoScale=False, | |||
There was a problem hiding this comment.
This would leave the annotations unscaled and cramped when there are more columns
There was a problem hiding this comment.
Yeah, I thought it cannot be that easy. I only happens for a single variable. If len(var) == 1? And have two different parameters, depending on the number of variables?
ajdapretnar
force-pushed
the
column-size-big
branch
from
a38b2d3
to
55828a4
Compare
|
@ajdapretnar Can you please check gh-4777 I think that should fix the underlying error. |
Codecov Report
@@ Coverage Diff @@
## master #4775 +/- ##
==========================================
+ Coverage 83.70% 83.82% +0.12%
==========================================
Files 275 276 +1
Lines 55620 55929 +309
==========================================
+ Hits 46557 46885 +328
+ Misses 9063 9044 -19 |
|
Will check and merge if it fixes the issue. |
|
Closed in favour of #4777. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Maybe fixes #4712.
Description of changes
Do not autoscale labels. I think that's what it does.
Includes