Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Several fixes in learners/models #4655

Merged
merged 4 commits into from
Apr 30, 2020

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Apr 15, 2020

Issue
  • Logistic regression uses MajorityLearner when only one class in data, while SVM fails
  • Softmax regression and NuSVM return the wrong shape of the probability matrix when one class missing in training data.
  • Now when the data_to_model_domain was introduced in a Model class it is duplicated in outliers.
  • Rules fail when empty list with new rules
Description of changes
  • LogisticRegressionLearner does not use MajorityLearner when only one class in data.
  • Softmax regression fixed to return the right shape of probability matrix (num cases x num classes in the domain)
  • NuSVM: removed own predict function, adding missing dimensions is now handled by predict function on SklModel
  • data_to_model_domain removed from outliers, added callbacks to data_to_model_domain in Model class
  • Rules fixed
Includes
  • Code changes
  • Tests

@PrimozGodec PrimozGodec force-pushed the fix-predictors branch 2 times, most recently from 2fc3112 to 13c100b Compare April 15, 2020 09:58
@PrimozGodec PrimozGodec added needs discussion Core developers need to discuss the issue and removed needs discussion Core developers need to discuss the issue labels Apr 15, 2020
@PrimozGodec PrimozGodec force-pushed the fix-predictors branch 3 times, most recently from 8594496 to f2f8f6e Compare April 20, 2020 10:31
@PrimozGodec PrimozGodec changed the title [WIP] Fix predictors [FIX] Several fixes in learners/models Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #4655 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master    #4655    +/-   ##
========================================
  Coverage   83.69%   83.69%            
========================================
  Files         280      275     -5     
  Lines       56447    55604   -843     
========================================
- Hits        47244    46539   -705     
+ Misses       9203     9065   -138     

@lanzagar lanzagar merged commit b5e910f into biolab:master Apr 30, 2020
@PrimozGodec PrimozGodec deleted the fix-predictors branch April 21, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants