[ENH] ApplyDomain: data info displayed in the status bar #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4611 +/- ##
==========================================
+ Coverage 83.62% 83.68% +0.05%
==========================================
Files 281 275 -6
Lines 56199 55573 -626
==========================================
- Hits 46995 46504 -491
+ Misses 9204 9069 -135 |
VesnaT
requested changes
Apr 2, 2020
| @@ -31,6 +35,7 @@ class Error(OWWidget.Error): | |||
| def __init__(self): | |||
| super().__init__() | |||
| self.data = None # type: Optional[Table] | |||
| self.template_data = None # type: Optional[Table] | |||
There was a problem hiding this comment.
Since self.template_data has been introduces self.template_domain is no longer needed.
| summary, details = "10", format_summary_details(output) | ||
| self.assertEqual(info._StateInfo__output_summary.brief, summary) | ||
| self.assertEqual(info._StateInfo__output_summary.details, details) | ||
|
|
There was a problem hiding this comment.
An extra line can be removed.
VesnaT
reviewed
Apr 14, 2020
aturanjanin
force-pushed
the
owtransform
branch
from
6a99ac7
to
4510fe2
Compare
VesnaT
reviewed
Apr 17, 2020
Orange/widgets/data/owtransform.py
Outdated
| self.apply() | ||
|
|
||
| def apply(self): | ||
| self.clear_messages() | ||
| transformed_data = None | ||
| if self.data and self.template_domain is not None: | ||
| if self.data and self.template_data is not None: |
There was a problem hiding this comment.
If self.template_data is not None, it evaluates to True (the is not None part is not necessary).
VesnaT
requested changes
Apr 17, 2020
Orange/widgets/data/owtransform.py
Outdated
| @@ -97,8 +119,8 @@ def apply(self): | |||
| def send_report(self): | |||
| if self.data: | |||
| self.report_data("Data", self.data) | |||
| if self.template_domain is not None: | |||
| self.report_domain("Template data", self.template_domain) | |||
| if self.template_data is not None: | |||
There was a problem hiding this comment.
If self.template_data is not None, it evaluates to True (the is not None part is not necessary).
aturanjanin
force-pushed
the
owtransform
branch
from
4510fe2
to
6bd7591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Input/output data info displayed in the status bar.
Includes