[FIX] Owpaintdata, owpivot: ensure unique domain #4578
Conversation
There was a problem hiding this comment.
I wrote a few minor comments about Paint data.
As for the Pivot, I may be looking at a wrong thing but it seems to me that attributes are created in _create_group_tables and __get_group_table, where they are combined with attributes that come from the code that you modified. If I am not mistaken, I think that you should rename attributes in __get_group_table.
Orange/widgets/data/owpaintdata.py
Outdated
| @@ -752,6 +753,7 @@ class Outputs: | |||
| table_name = Setting("Painted data") | |||
| attr1 = Setting("x") | |||
| attr2 = Setting("y") | |||
| unique_names = [attr1, attr2] | |||
There was a problem hiding this comment.
I suppose there is no reason to store unique_names? Even if there is, this here won't work: unique_names will contain two instances of Setting. attr1 and attr2 are changed to "x" and "y" only in the meta class, after the class' namespace is filled.
|
I think i forgot to rename some of them in __get_group_table, but renaming them in create_pivot_domain is also necessary, since some of the domains are created there. Note, that domains created there are not necessarily part of the output but are there to be drawn in the widget. Renaming the variables in multiple places can cause some inconsistencies though. |
Issue
Partialy fixes #4382
Includes