[RFC][ENH] OWScatterPlot: axis displays time specific labels for time variable #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertcv
force-pushed
the
enh/add_time_axis
branch
from
c76c0c4
to
4270d0f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4434 +/- ##
==========================================
+ Coverage 87.44% 87.46% +0.01%
==========================================
Files 405 405
Lines 74083 74201 +118
==========================================
+ Hits 64785 64897 +112
- Misses 9298 9304 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4395
Additional information
The labels can be changed according to
strftimeif anybody finds a better formating. It still doesn't look particularly nice when displaying days and hours. I also tried using binningshort_labelsbut they didn't seem that nice.The
timezone.utcis used becous of a Python datetime bug.Includes