[ENH] Import openTSNE lazily for faster loading of Orange #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4424 +/- ##
==========================================
- Coverage 87.47% 87.46% -0.01%
==========================================
Files 405 405
Lines 74135 74128 -7
==========================================
- Hits 64846 64836 -10
- Misses 9289 9292 +3 |
janezd
changed the title
|
I'll dare merging it. It won't be difficult to revert if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3523.
#3883 crashed travis for unknown reasons. This fix is implemented a bit differently and replaces the lazy object with actual module once it is loaded.
It survived three runs of tests. If we're worried about random crashes, we can restart a few more times.