Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] owheatmap: Add Split By combo box #4234

Merged
merged 2 commits into from
Nov 29, 2019

Conversation

ales-erjavec
Copy link
Contributor

Issue

Heat map splits vertically by discrete class variable. This is hardcoded in the widget but not always desired.

Description of changes

Allow (rows) split by other class or meta categorical var (not just the class var), or disable spliting at all.

Includes
  • Code changes
  • Tests
  • Documentation

Allow split by any categorical var (not just the class var), or disable
split at all
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #4234 into master will increase coverage by 0.07%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master    #4234      +/-   ##
==========================================
+ Coverage   85.95%   86.02%   +0.07%     
==========================================
  Files         394      394              
  Lines       70164    70122      -42     
==========================================
+ Hits        60310    60325      +15     
+ Misses       9854     9797      -57

@ajdapretnar
Copy link
Contributor

This is so great, I cannot even... 👌

@ajdapretnar ajdapretnar merged commit c58eaa4 into biolab:master Nov 29, 2019
@ales-erjavec ales-erjavec deleted the owheatmap-split-by branch March 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants