[FIX] Louvain Clustering: fix setting to restore correctly #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4187 +/- ##
==========================================
+ Coverage 85.78% 85.79% +0.01%
==========================================
Files 389 389
Lines 69871 69892 +21
==========================================
+ Hits 59938 59965 +27
+ Misses 9933 9927 -6 |
BlazZupan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4182, also when just chaning the dataset and changing it back settings did not restored.
Description of changes
Removed two lines that caused that settings did not restore to the old value. In my opinion, those two lines are not required since spin has the same functionality itself.
Includes