[FIX] util: Fix bincount for object arrays #3831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
bincount
failed for object arrays that containednp.nan
, but worked on both float arrays with nans and object arrays without them.This was a problem since metas are often stored as object arrays and contain primitive variables, for which bincount should work (even if there are missing values).
Description of changes
The array must contain numbers anyway (since it is later converted to int32 for np.bincount), so it should not hurt to cast it to float before checking for nans. Almost all arrays in Orange are either float or object anyway, so this should be a noop for float arrays and a fix for object arrays.
Includes