Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Reset settings button #3795

Merged
merged 5 commits into from
May 31, 2019
Merged

[ENH] Reset settings button #3795

merged 5 commits into from
May 31, 2019

Commits on May 31, 2019

  1. OWWidget: Add button for reset settings

    @janezd
    janezd committed May 31, 2019
    Configuration menu
    Copy the full SHA
    d7c1a0e View commit details
    Browse the repository at this point in the history

  2. OWNomogram: Add reset settings

    @janezd
    janezd committed May 31, 2019
    Configuration menu
    Copy the full SHA
    1ef60a6 View commit details
    Browse the repository at this point in the history

  3. A test for OWWidget._reset_settings

    @markotoplak @janezd
    markotoplak authored and janezd committed May 31, 2019
    Configuration menu
    Copy the full SHA
    f9eeeab View commit details
    Browse the repository at this point in the history

  4. OWNomogram: test for reset_settings

    @markotoplak @janezd
    markotoplak authored and janezd committed May 31, 2019
    Configuration menu
    Copy the full SHA
    256b91d View commit details
    Browse the repository at this point in the history

  5. OWWidget: remove method resetSettings 

    Method didn't really reset them (it reverted them to the saved state, not the
original), it wasn't used (except in a single place where it was unnecessary)
and, worst of all, its name was in camel case.

I believe the world is better without it.
    @janezd
    janezd committed May 31, 2019
    Configuration menu
    Copy the full SHA
    54fc253 View commit details
    Browse the repository at this point in the history