[FIX] OWAnchorProjectionWidget: Retain valid_data when reloading dataset #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3718 +/- ##
=======================================
Coverage 84.52% 84.52%
=======================================
Files 373 373
Lines 68459 68459
=======================================
Hits 57868 57868
Misses 10591 10591 |
VesnaT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3717
In case dataset with missing values was reloaded,
valid_datawas not properly set, becauseget_embedding()was not invoked.To reproduce: OWFile(heart_disease) -> OWRadviz -> OWFile(click Reload)
Description of changes
valid_dataonly inget_embedding().Includes