[FIX] Save Data: Remove extra file extensions #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3700 +/- ##
=========================================
+ Coverage 84.5% 84.5% +<.01%
=========================================
Files 373 373
Lines 68317 68323 +6
=========================================
+ Hits 57732 57739 +7
+ Misses 10585 10584 -1 |
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3667.
Description of changes
Qt's non-native file save dialog was giving wrong extensions: instead of iris.tab.gz it had iris.gz, or, sometimes, apparently iris.tab.tab.
Now the function for removing extensions chips away any parts of extension that can appear in any filter.
Includes