[FIX] Test & Score: hide warnings for hidden scores. #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3676 +/- ##
==========================================
- Coverage 84.5% 84.49% -0.01%
==========================================
Files 373 373
Lines 68253 68269 +16
==========================================
+ Hits 57675 57687 +12
- Misses 10578 10582 +4 |
janezd
reviewed
Mar 15, 2019
| item = QStandardItem() | ||
| if stat.success: | ||
| item.setText("{:.3f}".format(stat.value[0])) | ||
| else: | ||
| item.setToolTip(str(stat.exception)) | ||
| has_missing_scores = True | ||
| has_missing_scores = scorer.name in self.shown_scores |
There was a problem hiding this comment.
Should this be has_missing_scores = has_missing_scores or scorer.name in self.shown_scores? It can already be True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2088
A user sees a warning although all displayed scores are successfully computed. The problematic score is not AUC but LogLoss, which the widget tries to compute (and fails) but is not displayed by default.
Description of changes
We might want to consider fixing LogLoss for the case described in #2088.
Includes