Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] LinearProjection: Disable LDA for less than three classes #3615

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Feb 19, 2019

Issue

The widget crashed when feed a dataset with two classes.
To reproduce: File(heart_disease) -> LinearProjection(Select Linear Discriminant Analysis)

Description of changes

Disable Linear Discriminant Analysis when dataset has target with less than three classes.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #3615 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3615      +/-   ##
==========================================
- Coverage   84.07%   84.07%   -0.01%     
==========================================
  Files         370      370              
  Lines       67252    67256       +4     
==========================================
+ Hits        56541    56544       +3     
- Misses      10711    10712       +1

@janezd janezd merged commit 64461f9 into biolab:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants