Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Edit Domain: Add support for ordered categorical variables #3535

Merged
merged 3 commits into from
Jan 18, 2019

Conversation

ales-erjavec
Copy link
Contributor

Issue

'Edit Domain' widget does not allow changing the 'ordered' aspect of a categorical variable

Description of changes

Add an 'Ordered' check box control and implement the associated transform.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #3535 into master will increase coverage by <.01%.
The diff coverage is 98.38%.

@@            Coverage Diff             @@
##           master    #3535      +/-   ##
==========================================
+ Coverage   83.67%   83.68%   +<.01%     
==========================================
  Files         370      370              
  Lines       66176    66230      +54     
==========================================
+ Hits        55372    55423      +51     
- Misses      10804    10807       +3

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #3535 into master will increase coverage by 0.01%.
The diff coverage is 98.38%.

@@            Coverage Diff             @@
##           master    #3535      +/-   ##
==========================================
+ Coverage   83.67%   83.68%   +0.01%     
==========================================
  Files         370      370              
  Lines       66176    66230      +54     
==========================================
+ Hits        55372    55427      +55     
+ Misses      10804    10803       -1

@ajdapretnar ajdapretnar merged commit ab706a0 into biolab:master Jan 18, 2019
@ales-erjavec ales-erjavec deleted the oweditdomain-ordered branch May 20, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants