[ENH] Warn when data subset is unrelated to data #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
==========================================
+ Coverage 83.51% 83.52% +<.01%
==========================================
Files 367 367
Lines 65599 65635 +36
==========================================
+ Hits 54787 54819 +32
- Misses 10812 10816 +4 |
ajdapretnar
reviewed
Jan 4, 2019
Orange/data/table.py
Outdated
| vstack(collect("X")), | ||
| merge1d(collect("Y")), | ||
| vstack(collect("metas")), | ||
| merge1d(collect("W")) |
There was a problem hiding this comment.
Do we even support weights anywhere? 🤔
|
This PR seems to contain several disjointed commits. Is this supposed to be so? |
janezd
force-pushed
the
projection-invalid-subset
branch
from
af0f2d7
to
97d5bbd
Compare
|
Rebased to master that already includes #3500. |
|
This works well! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3292.
Also switches to
np.fromiterwhen constructing a subset mask to avoid creating a Python list.Includes