[FIX] Rank: Fix crash on dataset with missing values #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3458 +/- ##
==========================================
+ Coverage 83.25% 83.27% +0.01%
==========================================
Files 365 365
Lines 64300 64315 +15
==========================================
+ Hits 53534 53558 +24
+ Misses 10766 10757 -9 |
|
I can't reproduce the error with any regular data with missing values. I also can't find the mentioned datasets. Could you please tell me how to test this so I can merge? :) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
OWRank crashed when input dataset with missing values (i.e. testing_dataset_cls, testing_dataset_reg).
Description of changes
Includes