[FIX] OWDataProjectionWidget: Consider tables with nan-s equal #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3435 +/- ##
==========================================
+ Coverage 83.22% 83.22% +<.01%
==========================================
Files 362 362
Lines 64105 64106 +1
==========================================
+ Hits 53350 53354 +4
+ Misses 10755 10752 -3 |
VesnaT
changed the title
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When widget received (unchanged) data with missing values on the input (i.e. Reloading the file) the embedding was recalculated.
Description of changes
When comparing previous and current table.X, consider np.nan-s equal.
Includes