Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWWidget: Fix size hint propagation #3253

Conversation

ales-erjavec
Copy link
Contributor

Issue

Some widgets open with wrong initial position and size (see #3240 (comment))

Description of changes
  • Fix OWWidget._Splitter size hinting.
  • Force invalidation of cached size hints before showing the widget.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #3253 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3253      +/-   ##
==========================================
+ Coverage   82.82%   82.91%   +0.08%     
==========================================
  Files         346      349       +3     
  Lines       60211    63659    +3448     
==========================================
+ Hits        49870    52781    +2911     
- Misses      10341    10878     +537

@ajdapretnar ajdapretnar merged commit ee960d8 into biolab:master Sep 24, 2018
@ales-erjavec ales-erjavec deleted the fixes/owwidget-splitter-size-hint-propagation branch May 20, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants