Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Scatterplot: indicate overlap of points. #3177

Merged
merged 6 commits into from
Aug 24, 2018

Conversation

thocevar
Copy link
Contributor

@thocevar thocevar commented Aug 1, 2018

Issue

Implements #3028

Description of changes

Scatterplot computes the set of indices at each coordinate for later use in compute_sizes and compute_colors. The sizes are multiplied by log_2 of the number of points. The color represents the most frequent color (or one of them if there are several).

scatterplot-overlap

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #3177 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
- Coverage   82.74%   82.74%   -0.01%     
==========================================
  Files         344      344              
  Lines       59323    59328       +5     
==========================================
  Hits        49088    49088              
- Misses      10235    10240       +5

@VesnaT
Copy link
Contributor

VesnaT commented Aug 3, 2018

For me the updated scatter plot looks a bit confusing, since it states 'Same size', but there appear to be points of different sizes.
I suggest adding an option to Size drop down, which enables a user to set point sizes according to the number of overlapping points, and keeping the default look as it was.

@ajdapretnar
Copy link
Contributor

I agree. Adding an option to Size would make a lot of sense!

@thocevar thocevar changed the title [RFC] [ENH] Scatterplot: indicate overlap of points. [ENH] Scatterplot: indicate overlap of points. Aug 24, 2018
@astaric astaric merged commit d15cf88 into biolab:master Aug 24, 2018
@PrimozGodec PrimozGodec added this to the 3.16 milestone Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants