Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Replace use of obsolete QStyle.standardPixmap #3127

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

The QStyle.standardPixmap method is obsolete and will/should disappear in the future (http://pyqt.sourceforge.net/Docs/PyQt5/pyqt4_differences.html#deprecated-features)

Description of changes
  • Use standardIcon method
  • Also fix the inverse icon rendering in widget tool dock's header.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #3127 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3127   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files         335      335           
  Lines       58166    58166           
=======================================
  Hits        47887    47887           
  Misses      10279    10279

@lanzagar lanzagar merged commit 371a193 into biolab:master Jul 13, 2018
@ales-erjavec ales-erjavec deleted the fixes/canvas-dock-obsolete branch September 12, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants