[ENH] RecentFiles: Check for missing file in workflow dir #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3064 +/- ##
==========================================
+ Coverage 82.35% 82.36% +0.01%
==========================================
Files 335 336 +1
Lines 58258 58289 +31
==========================================
+ Hits 47979 48011 +32
+ Misses 10279 10278 -1 |
lanzagar
requested changes
Jul 6, 2018
VesnaT
force-pushed
the
recent_path
branch
3 times, most recently
from
56978e4
to
10b5db9
Compare
lanzagar
requested changes
Jul 13, 2018
| ) | ||
| search_paths = [("basedir", os.getcwd())] | ||
| self.assertIsNotNone(recent_path.resolve(search_paths)) | ||
| os.remove("test.tab") |
There was a problem hiding this comment.
This looks like a classic trap of removing a file at the end, which might not happen if something goes wrong before the remove statement.
And here it is actually not that unusual since you have an assert above that might fail - try running this test on master.
I think there should be some utility functions for testing on temporary files somewhere... In any case some form of finally: cleanup is needed and I suggest using python's TemporaryFiles too.
VesnaT
force-pushed
the
recent_path
branch
2 times, most recently
from
efda734
to
90ecf9a
Compare
VesnaT
force-pushed
the
recent_path
branch
2 times, most recently
from
b3f7b66
to
3928461
Compare
When opening saved workflow and file widget detects missing file, check if the file is placed in the same directory as workflow is saved.
lanzagar
changed the title
lanzagar
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When opening saved workflow and file widget detects missing file, check if the file is placed in the same directory as workflow is saved.
Includes