-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Display Widgets on Top option #3038
Conversation
@ales-erjavec, can you take a look? |
fd08364
to
6b2c5db
Compare
Codecov Report
@@ Coverage Diff @@
## master #3038 +/- ##
=========================================
Coverage ? 82.37%
=========================================
Files ? 335
Lines ? 57811
Branches ? 0
=========================================
Hits ? 47621
Misses ? 10190
Partials ? 0 |
On macOS all windows with the |
`Float Widgets on Top` menu option has changed. | ||
|
||
Update the flag on existing widgets. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to a setter (def set_show_widgets_on_top(self, state):
) record the state in an instance attribute, and use that instead of querying QSettings in __set_float_on_top
, so the state is local to the workflow and not shared between them.
Serialize to QSettings on close, like other canvas settings
@ales-erjavec , state is now stored as an instance attribute in WidgetManager. |
Does not really achieve the goal completely on my system (using dwm :)), but I could get the desired functionality even before this PR (and can still). |
Issue
When Canvas gets focus, all widgets get hidden behind it
Description of changes
View -> Float Widgets on Top flag to show widgets on top of all other windows.