[FIX] Projection widgets: transform data properly #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2871 +/- ##
==========================================
+ Coverage 81.91% 81.91% +<.01%
==========================================
Files 326 326
Lines 55997 56003 +6
==========================================
+ Hits 45868 45874 +6
Misses 10129 10129 |
jerneju
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Thanks to @markotoplak and his new widget (biolab/orange3-prototypes#117) a new issue has been found.
Data in widgets Radviz, FreeViz, and Linear Projection is not transformed properly. Data indices are not preserved.
Description of changes
Use
Table.transform.Includes