[FIX] canvas/addons: Fix progress dialog showing up when not necessary #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
changed the title
astaric
approved these changes
Dec 20, 2017
Orange/canvas/application/addons.py
Outdated
| self.__thread = None | ||
| self.__installer = None | ||
|
|
||
| if not self._f_pypi_addons.done(): | ||
| p = self.__progressDialog() |
Create the dialog only when starting a task.
ales-erjavec
force-pushed
the
fixes/addons-progress-dialog
branch
from
e2a5bd6
to
d9f60a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2833 +/- ##
=======================================
Coverage 81.96% 81.96%
=======================================
Files 321 321
Lines 54841 54841
=======================================
Hits 44952 44952
Misses 9889 9889 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Go to Options -> Add-ons, wait until it updates the packages list then close the dialog. Open Options -> Add-ons again. The dialog is populated immediately, but wait ~4 sec. A progress dialog shows up and does not go away until cancelled.
Description of changes
Create the dialog only when starting a task.
Includes