Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Scatter Plot Graph: vars instead of indices & remove dead code #2815

Merged
merged 2 commits into from
Dec 8, 2017
Merged

[FIX] Scatter Plot Graph: vars instead of indices & remove dead code #2815

merged 2 commits into from
Dec 8, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Dec 1, 2017

Issue
  1. somewhere still indices are used instead of vars
  2. some dead code found
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #2815 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2815      +/-   ##
=========================================
+ Coverage    76.2%   76.2%   +<.01%     
=========================================
  Files         337     337              
  Lines       59665   59658       -7     
=========================================
- Hits        45469   45465       -4     
+ Misses      14196   14193       -3

@jerneju jerneju requested a review from lanzagar December 4, 2017 11:56
@jerneju jerneju removed the request for review from lanzagar December 4, 2017 11:56
@jerneju jerneju added this to the 3.9 milestone Dec 5, 2017
@janezd janezd merged commit 11c27f6 into biolab:master Dec 8, 2017
@jerneju jerneju deleted the spg-vars-deadcode branch December 8, 2017 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants