-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Outliers widget no longer checks classes and doesn't crash on singular covariances matrices #2677
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2677 +/- ##
==========================================
- Coverage 75.65% 75.65% -0.01%
==========================================
Files 333 333
Lines 58422 58418 -4
==========================================
- Hits 44202 44197 -5
- Misses 14220 14221 +1 |
@@ -27,6 +28,7 @@ def mahalanobis(self, observations): | |||
class EllipticEnvelopeLearner(SklLearner): | |||
__wraps__ = skl_covariance.EllipticEnvelope | |||
__returns__ = EllipticEnvelopeClassifier | |||
preprocessors = [Continuize(), RemoveNaNColumns(), SklImpute()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these preprocessors used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 132 to 143 in 8ee65c0
def preprocess(self, data): | |
"""Apply the `preprocessors` to the data""" | |
for pp in self.active_preprocessors: | |
data = pp(data) | |
return data | |
@property | |
def active_preprocessors(self): | |
yield from self.preprocessors | |
if (self.use_default_preprocessors and | |
self.preprocessors is not type(self).preprocessors): | |
yield from type(self).preprocessors |
Issue
EllipticEnvelopeLearner
removes instances without classes.Fixes #2588.
Description of changes
EllipticEnvelopeLearner
Tests do not add much new; they passed before, too. The PR actually removes tests that checked for what shouldn't had been checked.
Includes