[FIX] Scatter Plot: remove dead and commented code, tests #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2627 +/- ##
==========================================
+ Coverage 75.17% 75.36% +0.18%
==========================================
Files 331 331
Lines 57769 57787 +18
==========================================
+ Hits 43429 43551 +122
+ Misses 14340 14236 -104 |
janezd
approved these changes
Oct 2, 2017
| def init_attr_values(self): | ||
| domain = self.data and self.data.domain | ||
| for model in self.models: | ||
| model.set_domain(domain) | ||
| self.attr_x = self.xy_model[0] if self.xy_model else None | ||
| self.attr_y = self.xy_model[1] if len(self.xy_model) >= 2 \ | ||
| else self.attr_x | ||
| self.graph.attr_color = domain and self.data.domain.class_var or None | ||
| self.graph.attr_color = self.data.domain.class_var if domain else None |
There was a problem hiding this comment.
The previous expression domain and self.data.domain.class_var or None is equivalent to self.data.domain.class_var if (domain and self.data.domain.class_var) else None, which is what I actually meant here. This is not the same as self.data.domain.class_var if domain else None, which assumes that self.data.domain.class_var is either a Variable or None (which, in fact, it is :) ). I'm just nitpicking; the previous expression was more explicit, but too unreadable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Dead code. Commented code. Low coverage.
Description of changes
Some code removed.
Coverage increased from 74% to 83%.
Includes