[FIX] tree: Fix min_samples_leaf check #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzagar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2507 +/- ##
==========================================
- Coverage 74.6% 74.53% -0.07%
==========================================
Files 321 321
Lines 56167 56167
==========================================
- Hits 41901 41864 -37
- Misses 14266 14303 +37 |
|
@lanzagar I can't reproduce this: |
|
Try the zoo data and select one instance from each class. Then try to build a full tree. |
|
Ahh, I see. I can reproduce now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Setting "Min. number of instances in leaves" (or
min_samples_leafin the code) to K actually enforced leaves to have K + 1 instances.Description of changes
Change the check for invalid nodes from
<= min_samples_leafto strict< min_samples_leafIncludes