[FIX] owhierarchicalclustering: Explicit geometry transform #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit transform/scale the dendrogram geometry to scene display coordinates and avoid use of cosmetic pens. Fixes biolabgh-2297
|
I tested this and it works, but codeclimate is globally misbehaving. Should I ignore it and just merge or wait for a pass? |
|
I haven't seen anything useful from Codeclimate so far, so I'm ignoring it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-2297
The cause of the broken PDF export was a non aspect preserving implicit dendrogram scaling and use of cosmetic pen to implement fast resize in response to user interaction. QPDFWriter however cannot handle cosmetic pens.
Description of changes
Explicit transform/scale the dendrogram geometry to scene display coordinates and avoid use of cosmetic pens.
Includes