[ENH] Canvas Annotations: Text markup editing #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-erjavec
force-pushed
the
canvas-annotations-rich-text
branch
from
ef62ee4
to
e3d0efd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2422 +/- ##
==========================================
+ Coverage 73.88% 74.23% +0.35%
==========================================
Files 320 320
Lines 55828 55828
==========================================
+ Hits 41247 41446 +199
+ Misses 14581 14382 -199 |
|
IIUC, the Windows build fails because CommonMark is not available on conda? |
ales-erjavec
force-pushed
the
canvas-annotations-rich-text
branch
from
e3d0efd
to
570cc9b
Compare
|
It failed because CommonMark was not listed in conda recipe. |
astaric
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Implements inline text markup editing for canvas annotations. Html, rst and markdown are supported.
Use alt-right click on the annotation to change how the content should be interpreted.
Description of changes
Includes