vizrank: interact with gui from main thread only #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were problems with vizrank crashing on some platforms.
|
Thank you. But there still persist some other problem (#2347). |
|
@jerneju Yes, that is an independent issue which I did not attempt to fix. |
Codecov Report
@@ Coverage Diff @@
## master #2389 +/- ##
==========================================
+ Coverage 73.28% 73.36% +0.08%
==========================================
Files 317 317
Lines 55519 55547 +28
==========================================
+ Hits 40685 40751 +66
+ Misses 14834 14796 -38 |
|
This is confirmed to fix an issue on Windows: Quasars/orange-spectroscopy#71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were problems with vizrank crashing on some platforms.
Issue
Vizrank was crashing on some platforms: Ubuntu 14.04 and 16.04 with PyQt4 and some Windows with PyQt5.
Fixes #2363.
Description of changes
Removed progressbar updates and some other GUI changes from the worker thread.
Includes